Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • S snp-best-practices
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • saltpepper
  • snp-best-practices
  • Issues
  • #10

Closed
Open
Created Jun 26, 2014 by Ghost User@ghostContributor

Rubocop compliance

config/environments/testing.rb:2:58: C: Final newline missing.
require Rails.root.join('config/environments/production')

config/unicorn.rb:2:17: W: (...) interpreted as grouped expression.
worker_processes (ENV['WORKER_COUNT'] || 2).to_i
                ^
config/unicorn.rb:7:42: C: Use && instead of and.
GC.respond_to?(:copy_on_write_friendly=) and
                                         ^^^
config/unicorn.rb:13:4: C: Put one space between the method name and the first argument.
pid               "#{deploy_to}/shared/tmp/pids/unicorn.pid"
   ^^^^^^^^^^^^^^^
config/unicorn.rb:14:12: C: Put one space between the method name and the first argument.
stderr_path       "#{deploy_to}/shared/log/unicorn.stderr.log"
           ^^^^^^^
config/unicorn.rb:15:12: C: Put one space between the method name and the first argument.
stdout_path       "#{deploy_to}/shared/log/unicorn.stdout.log"
           ^^^^^^^
config/unicorn.rb:17:25: W: Unused block argument - worker. If it's necessary, use _ or _worker as an argument name to indicate that it won't be used.
before_fork do |server, worker|
                        ^^^^^^
config/unicorn.rb:18:32: C: Use && instead of and.
  defined?(ActiveRecord::Base) and ActiveRecord::Base.connection.disconnect!
                               ^^^
config/unicorn.rb:21:11: W: File.exists? is deprecated in favor of File.exist?.
  if File.exists?(old_pid) && server.pid != old_pid
          ^^^^^^^
config/unicorn.rb:24:5: W: Do not suppress exceptions.
    rescue Errno::ENOENT, Errno::ESRCH
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
config/unicorn.rb:30:16: W: Unused block argument - server. You can omit all the arguments if you don't care about them.
after_fork do |server, worker|
               ^^^^^^
config/unicorn.rb:30:24: W: Unused block argument - worker. You can omit all the arguments if you don't care about them.
after_fork do |server, worker|
                       ^^^^^^
config/unicorn.rb:31:32: C: Use && instead of and.
  defined?(ActiveRecord::Base) and ActiveRecord::Base.establish_connection
                               ^^^
config/deploy/production.rb:3:15: C: %w-literals should be delimited by ( and )
       roles: %w{web app db},
              ^^^^^^^^^^^^^^
config/deploy/production.rb:10:11: C: Redundant curly braces around a hash parameter.
set :env, { worker_count: 8 }
          ^^^^^^^^^^^^^^^^^^^
config/deploy/production.rb:10:30: C: Final newline missing.
set :env, { worker_count: 8 }

config/deploy/testing.rb:3:15: C: %w-literals should be delimited by ( and )
       roles: %w{web app db},
              ^^^^^^^^^^^^^^
Assignee
Assign to
Time tracking